Lemmy Server's (lemmy_server) Rust code, stuck on use of return and how the general Ok / error return works

RoundSparrow · edit-2 2 years ago

Lemmy Server's (lemmy_server) Rust code, stuck on use of return and how the general Ok / error return works

@nous@programming.dev · edit-2 2 years ago

Looks to be failing a cargo fmt check: https://woodpecker.join-lemmy.org/repos/129/pipeline/1821/8

+ cargo +nightly-2023-07-10 fmt -- --check
Diff in /woodpecker/src/github.com/LemmyNet/lemmy/crates/utils/src/rate_limit/mod.rs at line 224:
 use std::sync::atomic::{AtomicUsize, Ordering};
 static CONCURRENT_API_USE: AtomicUsize = AtomicUsize::new(0);
 
-
 impl<s> Service for RateLimitedMiddleware<s>
 where
   S: Service + 'static,

If I read that right you have one extra blank new line that the nightly rust fmt is not happy about.

You should just need to run cargo fmt on the code, might need the same nightly version as above though.</s></s>

RoundSparrow · 2 years ago

Thank you, removed the whitespace for another run: https://github.com/LemmyNet/lemmy/pull/3805/commits/33cc3967452d6b4a0369e4f85b17ff121c89451d

@nous@programming.dev · 2 years ago

Looks like it is now failing on the SQL fmt checks - which you have not changed and so are likely a problem in master. Seems https://github.com/LemmyNet/lemmy/pull/3800 fixes that issue and you are likely going to need to wait for that to be merged first. Or otherwise talk to the maintainers about it since it is broken in master and there is aPR to fix the issue.

RoundSparrow · 2 years ago

Thank you!